Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret naive datetimes as UTC #686

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 14, 2024

Related Issue(s):

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski requested a review from jsignell May 14, 2024 17:49
@gadomski gadomski self-assigned this May 14, 2024
@gadomski gadomski force-pushed the issues/644-naive-datetime branch from 57a5a26 to 76b9629 Compare May 14, 2024 17:51
@gadomski gadomski force-pushed the issues/644-naive-datetime branch from 76b9629 to 7f57f80 Compare May 14, 2024 17:51
Copy link
Collaborator

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this is the better way to interpret datetimes without timezones.

Dunno when we do a changelog, but it it's at release time we'll want to call this out prominently.

@gadomski
Copy link
Member Author

Dunno when we do a changelog, but it it's at release time we'll want to call this out prominently.

Good point — I hadn't thought about that. Do you think it's enough of a change to warrant a "MAJOR" release (i.e. v0.8.0) to get people's attention?

@gadomski gadomski merged commit 3e02053 into main May 15, 2024
17 checks passed
@gadomski gadomski deleted the issues/644-naive-datetime branch May 15, 2024 13:26
@TomAugspurger
Copy link
Collaborator

Maybe. I'm a fan of @jacobtomlinson's effver. Getting users to pause and think about whether they're using naive datetime objects seems worthwhile.

@gadomski gadomski mentioned this pull request May 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search result depends on datetime format
2 participants